-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[78699] SiS validate /authenticate
csp type & acr
#16241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll properly review when the DB PR is complete, but just stating that this looks like the right approach
0e21fd7
to
8462064
Compare
3bd1751
to
24cac69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bramleyjl I am having an issue signing in locally:
|
Summary
type
&acr
during SiS/authorize
against saved ClientConfigservice_levels
andcredential_service_providers
attributes.idme
,logingov
,mhv
,dslogon
) & service_levels (ial1
,ial2
,loa1
,loa3
,min
).MalformedParamsError
with "Type|ACR is not valid".service_levels
andcredential_service_providers
attributes are already validated against the same constants.Related issue(s)
service_levels
andcredential_service_providers
attributes to ClientConfig #16238Testing done
service_levels
orcredential_service_providers
values of your chosen ClientConfig to remove the CSP type or ACR you wish to test with/authorize
call should fail with the following errorsWhat areas of the site does it impact?
SiS authentication.
Acceptance criteria